Skip to content

Add BigInt module #5531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

DZakh
Copy link
Member

@DZakh DZakh commented Jul 9, 2022

For now, it only contains type t, but it'll prevent us from breaking changes in the future, as well as allow start experimenting with third-party bindings.

@DZakh DZakh force-pushed the js-bigint-module branch 2 times, most recently from b327993 to bb3e30b Compare July 11, 2022 09:34
@DZakh
Copy link
Member Author

DZakh commented Jul 11, 2022

@cristianoc I can't figure out how to fix failing Github actions, could you help me, please?

@cristianoc cristianoc mentioned this pull request Jul 11, 2022
@cristianoc
Copy link
Collaborator

Did not notice this PR does not do anything.
Feel free to reopen with a PR that does something.

@cristianoc cristianoc closed this Jul 11, 2022
@DZakh
Copy link
Member Author

DZakh commented Jul 11, 2022

Isn't it will be troublesome to move from biging_val to BigInt.t in the next releases? It'll be another breaking change, I'd like to avoid.

@cristianoc
Copy link
Collaborator

Briefly:
1 the proposed PR was a breaking change.
2 it's possible to do the same without introducing a breaking change
3 there are seemingly race conditions creating trouble in CI when some core library files are changed, so all this needs to be postponed until that is resolved

Example of non-breaking way: #5539

@DZakh
Copy link
Member Author

DZakh commented Jul 11, 2022

I see, you're right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants